-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement resolve query set (#3489 #3489
Implement resolve query set (#3489 #3489
Conversation
This is a good start, but I don't think I can merge this just yet - because this brings us in line with the upstream api, we also need the native api to behave the same. Once this merges, you'd need two different sets of flags to do query resolves. This should also change the validation of the resolve query to check for the RESOLVE_QUERY usage. If anything is confusing about that transformation, please feel free to ask questions over on the matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a breaking change, could you add an entry in the "major changes" explaining what changed? After that, this looks g2g
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
Describe what problem this is solving, and how it's solved.
I've added the missing
BufferUsages::QUERY_RESOLVE
(https://www.w3.org/TR/webgpu/#buffer-usage) and implementedcommand_encoder_resolve_query_set
for the WebGPU backend.Testing
Unfortunately, the WebGPU backend is broken in v0.15.1, so I only tested this with a personal project and my own patch for v0.14.2.