[GL] Unbind Vertex Buffers After Renderpass #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
fix-vertex-buffer-invalidation
branch
from
0fc91e0 to
bc1ecb3
Compare
cwfitzgerald
force-pushed
the
fix-vertex-buffer-invalidation
branch
from
bc1ecb3 to
ca08915
Compare
cwfitzgerald
changed the title
cwfitzgerald
force-pushed
the
fix-vertex-buffer-invalidation
branch
from
d57d0d9 to
7599867
Compare
auto-merge was automatically disabled
February 9, 2023 00:26
Merge queue setting changed
cwfitzgerald
removed this pull request from the merge queue due to the queue being cleared
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 9, 2023
cwfitzgerald
added a commit
that referenced
this pull request
Feb 9, 2023
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #3457
Description
We never reset the vertex buffers on the same command buffer.
Testing
Added regression test