Support stencil-only views and copying to/from combined depth-stencil textures #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Feb 1, 2023
teoxoy
force-pushed
the
depth-stencil-only-support
branch
from
4e04893 to
b6a6ccf
Compare
|
I created a It should test depth view creation indirectly since it's needed for the copy via shader and to test stencil view creation, there is some commented out code to do so. One thing worth noting is that once we get the CTS up and running, it should also test copying to/from combined depth-stencil textures and creation of stencil-only views. |
teoxoy
force-pushed
the
depth-stencil-only-support
branch
7 times, most recently
from
b538f9f to
36e4df7
Compare
teoxoy
force-pushed
the
depth-stencil-only-support
branch
from
36e4df7 to
1bcd63e
Compare
|
WARP is failing with... My Nvidia dGPU and Intel iGPU run the test without issues. |
teoxoy
force-pushed
the
depth-stencil-only-support
branch
from
1bcd63e to
0133bcc
Compare
|
The |
… textures - break down `describe` into `block_dimensions`, `required_features`, `guaranteed_format_features`, `sample_type` and `block_size` - `sample_type` and `block_size` now take an optional `TextureAspect` To enable copying to/from combined depth-stencil textures: - [validation] copy aspect must refer to a single aspect of format - [validation] update `validate_linear_texture_data` according to the WebGPU spec - [validation] require missing `DEPTH_TEXTURE_AND_BUFFER_COPIES` downlevel flag for `queue_write_texture` and `command_encoder_copy_buffer_to_texture` - [metal] set the right `MTLBlitOption` for texture/buffer copies - [dx12] use specific copy texture formats and set the right texture plane To create stencil-only views from combined depth-stencil textures: - [metal] set the right format `X24_Stencil8`/`X32_Stencil8` for the view and `MTLTextureUsage::PixelFormatView` for the texture - [gles] set the right `DEPTH_STENCIL_TEXTURE_MODE` to either `DEPTH_COMPONENT` or `STENCIL_INDEX` - [dx12] set the right formats `DXGI_FORMAT_X32_TYPELESS_G8X24_UINT` and `DXGI_FORMAT_X24_TYPELESS_G8_UINT`
teoxoy
force-pushed
the
depth-stencil-only-support
branch
from
5c6c1b7 to
00209f3
Compare
|
Should be good to go now. |
cwfitzgerald
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General changes:
describeintoblock_dimensions,required_features,guaranteed_format_features,sample_typeandblock_sizesample_typeandblock_sizenow take an optionalTextureAspectTo enable copying to/from combined depth-stencil textures:
validate_linear_texture_dataaccording to the WebGPU specDEPTH_TEXTURE_AND_BUFFER_COPIESdownlevel flag forqueue_write_textureandcommand_encoder_copy_buffer_to_textureMTLBlitOptionfor texture/buffer copiesTo create stencil-only views from combined depth-stencil textures:
X24_Stencil8/X32_Stencil8for the view andMTLTextureUsage::PixelFormatViewfor the textureDEPTH_STENCIL_TEXTURE_MODEto eitherDEPTH_COMPONENTorSTENCIL_INDEXDXGI_FORMAT_X32_TYPELESS_G8X24_UINTandDXGI_FORMAT_X24_TYPELESS_G8_UINT