Prefer the specific number of frames in a swap chain #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is straightforward. |
bors bot
added a commit
that referenced
this pull request
Sep 11, 2019
338: Prefer the specific number of frames in a swap chain r=kvark a=kvark Fixes gfx-rs/wgpu-rs#72 Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
338: Add Extension/Limit Interface r=kvark a=cwfitzgerald Follow up to gfx-rs#690. This forwards the extension/limit access interface into wgpu-rs. It appears that the web-sys doesn't actually implement any of the methods we need, so I had them return the defaults. `Device::limits` exists, but it returns `Object` not `GpuLimits`, so doesn't appear usable. Co-authored-by: Connor Fitzgerald <[email protected]>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
345: Rustify the example's use of Extensions and SamplerDescriptor r=kvark a=cwfitzgerald Implements gfx-rs#696. This didn't change any content from gfx-rs#338, just interface, but I tested a couple examples and it seems to work okay. Co-authored-by: Connor Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gfx-rs/wgpu-rs#72