Fix panic in the GLES backend when creating a pipeline with opaque ty… #3361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pes other than samplers.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Done, with
--feature gles
.Connections
Fixes issue #3337
Description
wgpu_hal::gles::device::Device::create_pipeline
was taking into account sampler types when collectingUniformDesc
s, but not other opaque types such as images and atomic counters,which led to the
panic!
here:wgpu/wgpu-hal/src/gles/conv.rs
Lines 442 to 453 in a06ef71
This PR adds checks for these other opaque types in addition to samplers.
Testing
Tested locally on my Galaxy S20 Ultra 5G, confirming the result of the
textureStore
in theglDispatchCompute
with RenderDoc.