Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix texture view creation with full-resource views when using an explicit mip_level_count or array_layer_count #3323

Merged

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Dec 21, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description

Two standalone commits:

  • Make doctests and tests run wgpu-types' tests.
  • Fix issue where explicitly spelled out full-resource views would not work correctly, causing metal validation to get mad when the surface texture was used this way.

Testing

Tested against rend3, and with explicit doctests.

@cwfitzgerald cwfitzgerald changed the title Make sure all doctests and tests in wgpu-types run Fix texture view creation with full-resource views when using an explicit mip_level_count or array_layer_count Dec 21, 2022
@cwfitzgerald cwfitzgerald force-pushed the fix-framebuffer-only-textures branch from ec25641 to 801b8cb Compare December 21, 2022 18:29
…icit `mip_level_count` or `array_layer_count`
@cwfitzgerald cwfitzgerald force-pushed the fix-framebuffer-only-textures branch from 801b8cb to 2c50cd2 Compare December 21, 2022 18:41
@cwfitzgerald cwfitzgerald merged commit aa46e82 into gfx-rs:master Dec 21, 2022
@cwfitzgerald cwfitzgerald deleted the fix-framebuffer-only-textures branch December 21, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants