Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate gfx_select's #[cfg] conditions at the right time. #3253

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Dec 2, 2022

See the comments in the code for details.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy force-pushed the gfx_select_cfg_conditions branch from 26a8487 to f64de4e Compare December 2, 2022 02:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #3253 (f64de4e) into master (46b1216) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
+ Coverage   65.41%   65.60%   +0.19%     
==========================================
  Files          82       82              
  Lines       39455    39468      +13     
==========================================
+ Hits        25809    25894      +85     
+ Misses      13646    13574      -72     
Impacted Files Coverage Δ
wgpu-core/src/lib.rs 96.55% <ø> (ø)
wgpu-core/src/hub.rs 60.67% <0.00%> (-0.31%) ⬇️
wgpu-core/src/device/queue.rs 70.51% <0.00%> (-0.19%) ⬇️
wgpu-core/src/validation.rs 58.87% <0.00%> (-0.14%) ⬇️
wgpu-core/src/command/clear.rs 89.58% <0.00%> (-0.04%) ⬇️
wgpu-core/src/track/texture.rs 80.97% <0.00%> (-0.02%) ⬇️
wgpu/src/util/mod.rs 12.50% <0.00%> (ø)
wgpu-core/src/instance.rs 65.92% <0.00%> (ø)
wgpu-types/src/lib.rs 88.12% <0.00%> (+0.05%) ⬆️
wgpu-core/src/error.rs 41.60% <0.00%> (+0.72%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jimblandy jimblandy force-pushed the gfx_select_cfg_conditions branch 2 times, most recently from 6800d4d to d51b803 Compare December 2, 2022 22:07
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus comment

wgpu-core/src/lib.rs Show resolved Hide resolved
@jimblandy jimblandy force-pushed the gfx_select_cfg_conditions branch from d51b803 to 0254e3e Compare December 5, 2022 20:34
See the comments in the code for details.
@jimblandy jimblandy force-pushed the gfx_select_cfg_conditions branch from 0254e3e to 99619f1 Compare December 5, 2022 20:35
@jimblandy jimblandy merged commit 537f077 into gfx-rs:master Dec 5, 2022
@jimblandy jimblandy deleted the gfx_select_cfg_conditions branch December 13, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants