Allow unspecified bits when deserializing the API's bitflags #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #3229 +/- ##
==========================================
+ Coverage 64.70% 65.67% +0.96%
==========================================
Files 81 63 -18
Lines 38819 34310 -4509
==========================================
- Hits 25118 22532 -2586
+ Misses 13701 11778 -1923
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nical
force-pushed
the
bitflags-serde
branch
3 times, most recently
from
d5e77b0 to
0ff92a6
Compare
cwfitzgerald
requested changes
Nov 23, 2022
nical
force-pushed
the
bitflags-serde
branch
from
0ff92a6 to
168bee0
Compare
cwfitzgerald
approved these changes
Nov 24, 2022
|
Got some merge conflicts |
The bitflags_serde_shim treats unspecified bits as errors during deserialization. To make the browser integration easier, we want the unsepcified bits (which can be produced by web content) to turn into validation errors instead of panics during deserialization. Thankfully the bitflags_serde_shim crate is quite trivial, so this PR inlines the macro with the required modification to not check the bits. In addition, bitflags_serde_shim feature is removed, the Serialize and Deserialize implementations are aways the same and only their presence depend on the trace and replay feature flags.
nical
force-pushed
the
bitflags-serde
branch
from
168bee0 to
d27dd4e
Compare
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.Connections
https://bugzilla.mozilla.org/show_bug.cgi?id=1771246 and a host of similar fuzz bugs where web content serves us unspecified bits in some of the API's bitflags.
Description
The bitflags_serde_shim crate treats unspecified bits as errors during deserialization. To make the browser integration easier, we want the unsepcified bits (which can be produced by web content) to turn into validation errors instead of panics during deserialization.
Thankfully the bitflags_serde_shim crate is quite trivial, so this PR inlines the macro with the required modification to not check the bits. In addition, bitflags_serde_shim feature is removed, the Serialize and Deserialize implementations are always the same and only their presence depend on the trace and replay feature flags.
Testing
A test for invalid buffer usage bits in create_buffer.