Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-deny to CI #3185

Merged
merged 8 commits into from
Nov 30, 2022
Merged

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 7, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file. Not sure if this is worth doing for downstream, skipping for now.
  • Ensure that codecov is happy.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

None, AFAIK!

Description
Describe what problem this is solving, and how it's solved.

Right now, wgpu's CI doesn't take advantage of nice tooling to audit dependencies. cargo-deny is a fantastic suite of dependency checks that's relatively popular in the Rust community. Add an invocation of cargo deny check as a step in the ci workflow; create configuration; adjust run-wasm's licensing so that it passes.

Testing
Explain how this change is tested.

TODO: Waiting to see how CI handles this.

There are some duplicate dependencies noted, but I doubt it's a problem that will be interesting to tackle except as occasional maintenance, rather than a hard CI check. Leaving as a warning for now.

.deny.toml Show resolved Hide resolved
.deny.toml Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #3185 (b792b23) into master (6ed103e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   64.73%   64.70%   -0.03%     
==========================================
  Files          81       81              
  Lines       38747    38819      +72     
==========================================
+ Hits        25084    25119      +35     
- Misses      13663    13700      +37     
Impacted Files Coverage Δ
wgpu-core/src/track/range.rs 92.85% <0.00%> (-2.15%) ⬇️
wgpu-core/src/command/transfer.rs 70.03% <0.00%> (-0.74%) ⬇️
wgpu-hal/src/gles/queue.rs 61.32% <0.00%> (-0.34%) ⬇️
wgpu-hal/src/gles/command.rs 69.82% <0.00%> (-0.26%) ⬇️
wgpu/src/backend/direct.rs 55.10% <0.00%> (-0.16%) ⬇️
wgpu-core/src/device/queue.rs 70.69% <0.00%> (-0.12%) ⬇️
wgpu-types/src/lib.rs 88.04% <0.00%> (ø)
wgpu-hal/src/gles/egl.rs 37.82% <0.00%> (ø)
wgpu-hal/src/gles/mod.rs 61.53% <0.00%> (ø)
wgpu-core/src/resource.rs 25.13% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Nov 8, 2022

@cwfitzgerald: I've just added a sources configuration to this PR with fd10de7. LMK what you think. 🙂

@ErichDonGubler
Copy link
Member Author

Tagging @teoxoy and @jimblandy for 👀.

@ErichDonGubler ErichDonGubler marked this pull request as ready for review November 8, 2022 14:52
@ErichDonGubler
Copy link
Member Author

RE: the above codecov report: I'm sure that this is reported as a regression because, at the time, many coverage tests weren't actually running. This should be fixed now, but @codecov-commenter hasn't posted another comment yet. ☹️

@cwfitzgerald
Copy link
Member

Fwiw, I think we need to tune the codecov comment, it's rather annoying.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ErichDonGubler ErichDonGubler force-pushed the cargo-deny branch 3 times, most recently from 914db99 to 1a68570 Compare November 14, 2022 15:57
@cwfitzgerald cwfitzgerald merged commit 9bb2d28 into gfx-rs:master Nov 30, 2022
@ErichDonGubler ErichDonGubler deleted the cargo-deny branch December 16, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants