-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-deny
to CI
#3185
Add cargo-deny
to CI
#3185
Conversation
917395a
to
b45ba07
Compare
b45ba07
to
400532e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
==========================================
- Coverage 64.73% 64.70% -0.03%
==========================================
Files 81 81
Lines 38747 38819 +72
==========================================
+ Hits 25084 25119 +35
- Misses 13663 13700 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@cwfitzgerald: I've just added a |
Tagging @teoxoy and @jimblandy for 👀. |
b792b23
to
0a413ee
Compare
RE: the above |
Fwiw, I think we need to tune the codecov comment, it's rather annoying. |
914db99
to
1a68570
Compare
b2d8a2f
to
73486f9
Compare
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Add change to CHANGELOG.md. See simple instructions inside file.Not sure if this is worth doing for downstream, skipping for now.codecov
is happy.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
None, AFAIK!
Description
Describe what problem this is solving, and how it's solved.
Right now,
wgpu
's CI doesn't take advantage of nice tooling to audit dependencies.cargo-deny
is a fantastic suite of dependency checks that's relatively popular in the Rust community. Add an invocation ofcargo deny check
as a step in theci
workflow; create configuration; adjustrun-wasm
's licensing so that it passes.Testing
Explain how this change is tested.
TODO: Waiting to see how CI handles this.
There are some duplicate dependencies noted, but I doubt it's a problem that will be interesting to tackle except as occasional maintenance, rather than a hard CI check. Leaving as a warning for now.