-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DEPTH24PLUS_STENCIL8
feature
#3151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
+ Coverage 64.76% 64.80% +0.04%
==========================================
Files 81 81
Lines 38764 38751 -13
==========================================
+ Hits 25106 25114 +8
+ Misses 13658 13637 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I just tested this on my WebGL build of maplibre-rs and it still errors with:
Tested on Firefox and Chrome with WebGL. EDIT: Depth24PlusStencil8 works on Firefox with WebGL. So DEPTH32FLOAT_STENCIL8 is probably just unsupported in browsers. |
I think you meant here Depth32FloatStencil8 right? |
No, this change addresses the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will backport shortly
Co-authored-by: Lilith <[email protected]>
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
#3112
Description
Removes the
DEPTH24PLUS_STENCIL8
feature. The feature is not present in the WebGPU spec and was blocking the use of theDepth24PlusStencil8
texture format on several platforms that support it. Tests have been adjusted to includeDepth24PlusStencil8
inclear_texture_2d_uncompressed
instead of having its own test.Testing
The change passes tests, and has been briefly tested locally on a Windows machine with an RTX 2080, using the Vulkan and WebGL backends.