Lower some data into the wgpu-core storages #3106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
force-pushed
the
lower-core-data
branch
2 times, most recently
from
935629e to
1b117c5
Compare
i509VCB
force-pushed
the
lower-core-data
branch
from
1b117c5 to
95cc87f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3106 +/- ##
===========================================
+ Coverage 1.34% 64.75% +63.41%
===========================================
Files 70 81 +11
Lines 18683 38739 +20056
===========================================
+ Hits 251 25087 +24836
+ Misses 18432 13652 -4780
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
i509VCB
changed the title
|
Going to delay this temporarily since I have a solution which is working in #3051 |
|
As this MR is currently stale, I'm going to close it for triage purposes. Please feel-free to re-open there is renewed interest in landing these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Related to #3051 and the work to move that pull request towards using Ids instead of Boxes.
Description
In order for all the assoicated types in the native backend to be ids we can convert directly, we need to lower some of the data associated with some types into the tracker instead of living next to the ids.
However this is a challenge to do and this pull request is here to explore the idea or find a better alternative. There are still some types which may need data lowered into the tracker or living in a type erased form along side ids. Namely RenderPass, ComputePass and RenderBundleEncoder carry a large amount of data along.
Testing
Local tests appear to run fine.