-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expose-ids
feature
#3104
Add expose-ids
feature
#3104
Conversation
Are these changes related to #3051? |
@i509VCB this particular use case is for unique identification of various resources for use in a cache, they need to be globally unique, not just unique-at-any-one-time. |
4240d8a
to
88d42db
Compare
Codecov Report
@@ Coverage Diff @@
## master #3104 +/- ##
==========================================
- Coverage 64.75% 64.74% -0.02%
==========================================
Files 81 81
Lines 38711 38747 +36
==========================================
+ Hits 25066 25085 +19
- Misses 13645 13662 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
88d42db
to
9fbd0ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great outside of a small comment
Sorry for the long delay in reviewing |
1d30c08
to
d8b2b1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Discussed in matrix
Description
Adds the
expose-ids
feature, which allows API users to compare and store the identity of GPU objects through an opaqueId
type. On native,Id
wraps an unzippedwgc::TypedId
; on web,Id
wraps a manually-generated uniqueu64
.Most types with an
id
field now expose a feature-gatedglobal_id
method.Testing
Not functionally tested yet, only typechecked
Unresolved Questions
Id
s be type-tagged, and if so, should there still be an untyped option?Context
s on native?