Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Hash for DepthStencilState and DepthBiasState #3092

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Implement Hash for DepthStencilState and DepthBiasState #3092

merged 4 commits into from
Oct 11, 2022

Conversation

killianc3
Copy link
Contributor

@killianc3 killianc3 commented Oct 11, 2022 •
edited by cwfitzgerald
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Hopefully, a simple solution for this issue : closes #3087

Description
As described in the question DepthStencilState and DepthBiasState doesn't have a Hash implementation, I tried to manage the implementation manually. I've never done this before, so it may not be perfect, but I'm interested in your opinion on this.

Testing
Cargo fmt / test / clippy.

cwfitzgerald
cwfitzgerald requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, some small comments

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cwfitzgerald
cwfitzgerald approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) October 11, 2022 18:59
@killianc3
Copy link
Contributor Author

Thanks again !

@cwfitzgerald cwfitzgerald merged commit 0951b03 into gfx-rs:master Oct 11, 2022
@killianc3 killianc3 deleted the dev branch October 11, 2022 19:14
@Wumpf
Copy link
Member

Wumpf commented Oct 12, 2022

🙇 thank you. I was just now needing this 😄

@Wumpf Wumpf mentioned this pull request Oct 12, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

derive(Hash) for DepthStencilState and DepthBiasState
3 participants
@killianc3 @Wumpf @cwfitzgerald