Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: call create_query_set and write_timestamp of web-sys #3091

Merged
merged 1 commit into from
Oct 13, 2022
Merged

web: call create_query_set and write_timestamp of web-sys #3091

merged 1 commit into from
Oct 13, 2022

Conversation

jinleili
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Testing
Tested locally via Chrome Canary

cwfitzgerald
cwfitzgerald requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to change any feature detection code?

wgpu/src/backend/web.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 42be6f3 into gfx-rs:master Oct 13, 2022
@jinleili jinleili deleted the web branch October 13, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @cwfitzgerald