Buffer usages mismatch check and documentation for mapped_at_creation size requirement. #3023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RunRUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
I based this on the documented validation behavior:
Description
Buffer usage mismatch validation was lost to a refactor. Specifically, this is the check needed when one of the
MAP_*
usages is enabled. This re-adds the check.I also added some documentation on the the validation of the buffer size when
mapped_at_creation
istrue
.Testing
A test was added at
wgpu/tests/buffer_usage.rs
. I confirmed that improper combinations were being allowed via this test and that with the changes they now fail validation.