Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document wgpu_core id handling, factories, etc. #2973

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Aug 19, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

@jimblandy jimblandy force-pushed the document-id-handling branch from 98d54aa to d1d48a5 Compare August 19, 2022 23:07
- Derive `Eq` where possible.

- Remove some needless `&*` circumlocution.

- Use `unsigned_abs` where appropriate.

- #[allow] some extraneous Clippy complaints in tests.
@jimblandy jimblandy force-pushed the document-id-handling branch from d1d48a5 to 418acea Compare August 20, 2022 19:11
@jimblandy
Copy link
Member Author

BTW, this is now dependent on #2977.

@jimblandy jimblandy requested a review from cwfitzgerald August 25, 2022 18:09
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well documented

@cwfitzgerald cwfitzgerald merged commit a0dfb28 into gfx-rs:master Aug 28, 2022
@jimblandy jimblandy deleted the document-id-handling branch September 23, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants