Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the vk::Queue in the Vulkan hal #2950

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

anlumo
Copy link
Contributor

@anlumo anlumo commented Aug 7, 2022

Connections

Followup to #2667.

Description

Allows users of wgpu to access vk::Queue using a simple accessor in the Vulkan backend.

@i509VCB
Copy link
Contributor

i509VCB commented Aug 8, 2022

Would it be useful to also expose the vk::Queue on the Vulkan hal's Queue type?

@anlumo
Copy link
Contributor Author

anlumo commented Aug 8, 2022

Would it be useful to also expose the vk::Queue on the Vulkan hal's Queue type?

I have looked into that, but I couldn't find a way to access the wgpu_hal::Queue from the wgpu::Queue, so it was kinda pointless. The wgpu::Queue only has a QueueId, which is a key in a hash table for looking up the device (at least that's what I understood from the code).

@i509VCB
Copy link
Contributor

i509VCB commented Aug 8, 2022

Would it be useful to also expose the vk::Queue on the Vulkan hal's Queue type?

I have looked into that, but I couldn't find a way to access the wgpu_hal::Queue from the wgpu::Queue, so it was kinda pointless. The wgpu::Queue only has a QueueId, which is a key in a hash table for looking up the device (at least that's what I understood from the code).

ah okay so it doesn't make sense to expose then

wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 6348a07 into gfx-rs:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants