Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update present_mode docs as most of them don't automatically fall back to Fifo anymore. #2855

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

Elabajaba
Copy link
Contributor

@Elabajaba Elabajaba commented Jul 5, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description

PresentMode docs on the SurfaceConfiguration struct were outdated due to #2803, so I updated them. I also added Wayland as a common platform that Immediate mode doesn't work on.

PresentMode no longer automatically falls back to Fifo
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
Auto(No)Vsync fallback wording.

Co-authored-by: Connor Fitzgerald <[email protected]>
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add it to the changelog under documentation and we're good!

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (rebase) July 5, 2022 20:48
@cwfitzgerald cwfitzgerald disabled auto-merge July 5, 2022 20:48
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) July 5, 2022 20:48
@cwfitzgerald cwfitzgerald merged commit ab340ba into gfx-rs:master Jul 5, 2022
@Elabajaba Elabajaba deleted the PresentMode-docs branch July 6, 2022 17:28
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Jul 14, 2022
…k to Fifo anymore. (gfx-rs#2855)

* space

PresentMode no longer automatically falls back to Fifo

* Update wgpu-types/src/lib.rs

Auto(No)Vsync fallback wording.

Co-authored-by: Connor Fitzgerald <[email protected]>

* changelog

Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald added a commit that referenced this pull request Jul 14, 2022
…k to Fifo anymore. (#2855)

* space

PresentMode no longer automatically falls back to Fifo

* Update wgpu-types/src/lib.rs

Auto(No)Vsync fallback wording.

Co-authored-by: Connor Fitzgerald <[email protected]>

* changelog

Co-authored-by: Connor Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants