Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
Problem: It is not obvious for users to create spriv shader modules when consulting docs of
wgpu::ShaderSource::SpirV
. The signature ofSpirV(Cow<'a, [u32]>)
alone doesn't given enough information. And the return type ofinclude_spirv!
is also not documented.See:
Proposed documents enhancement:
include_spirv!
andutil::make_spirv
include_spirv!
Testing
Has built documents and checked added links with the following commands: