Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform "valid to use with" checks when recording render bundles. #2690

Merged
merged 2 commits into from
May 28, 2022
Merged

Perform "valid to use with" checks when recording render bundles. #2690

merged 2 commits into from
May 28, 2022

Conversation

jimblandy
Copy link
Member

Also, update module docs for wgpu_core::commands::bundle.

@jimblandy jimblandy added the area: validation Issues related to validation, diagnostics, and error handling label May 23, 2022
@jimblandy jimblandy force-pushed the bundle-validation branch from 4c6d246 to 7861037 Compare May 23, 2022 06:29
cwfitzgerald
cwfitzgerald requested changes May 24, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

wgpu-core/src/validation.rs Outdated Show resolved Hide resolved
@jimblandy jimblandy force-pushed the bundle-validation branch from 7861037 to eba248a Compare May 25, 2022 03:37
@jimblandy
Copy link
Member Author

(just rebased, comments not addressed)

@jimblandy jimblandy force-pushed the bundle-validation branch from eba248a to 7160a0a Compare May 25, 2022 03:43
@jimblandy
Copy link
Member Author

okay, comment addressed

@jimblandy jimblandy requested a review from cwfitzgerald May 25, 2022 03:43
cwfitzgerald
cwfitzgerald requested changes May 28, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more error comment, this time with a suggestion.

wgpu-core/src/command/bundle.rs Outdated Show resolved Hide resolved
@jimblandy jimblandy force-pushed the bundle-validation branch from 7160a0a to 2e4a7c6 Compare May 28, 2022 08:44
@jimblandy jimblandy requested a review from cwfitzgerald May 28, 2022 08:44
cwfitzgerald
cwfitzgerald approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) May 28, 2022 08:56
@cwfitzgerald cwfitzgerald merged commit 0c0bbdb into gfx-rs:master May 28, 2022
@jimblandy jimblandy deleted the bundle-validation branch May 28, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
area: validation Issues related to validation, diagnostics, and error handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @cwfitzgerald