Clean up render bundle bind group tracking. #2679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dynamic_offsets` and `is_dirty` flags only make sense when the slot is occupied, so they should be inside the `Option`. This makes `State::bind` into an `ArrayVec<Option<BindState>>`, and cleans up various other bits.
jimblandy
force-pushed
the
render-bundle-binding-cleanup
branch
from
8709a22 to
f80f9af
Compare
|
Err, with this change Note, by the way, that a doc commit is split out from the code changes, for easier review. |
|
Merged in #2684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
wgpu_core::command::bundle::BindState, thedynamic_offsetsandis_dirtyflags only make sense when the slot is occupied, so they should be inside theOption. Doing so makesState::bindinto anArrayVec<Option<BindState>>, and cleans up various other bits.Document some parts of wgpu_core's render bundle code.