Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Optimization and Rewrite #2662

Merged
merged 39 commits into from
May 24, 2022

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented May 15, 2022

Connections

BVE-Reborn/rend3#350

Description

This PR completely rewrites the tracking system to be more cache friendly. It also restructures how texture tracking works, splitting states into "simple" and "complex" states.

TODO:

  • investigate dx12 buffer validation errors
  • Insert needs to deal with beginning/end state correctly
  • change STORAGE_WRITE to STORAGE_READ_WRITE
  • document everything
  • investigate if function names should be changed
  • set trace logging so it's easy to debug the trackers without blindly printing the whole tracker every time
  • Final pass over all the code

Testing

Ran through testing framework and external benchmarks.

@cwfitzgerald cwfitzgerald force-pushed the tracking-optimization branch from 740a182 to 71035d0 Compare May 16, 2022 22:25
@cwfitzgerald cwfitzgerald force-pushed the tracking-optimization branch from 9a23b3f to 0b8ce17 Compare May 17, 2022 04:07
@cwfitzgerald cwfitzgerald force-pushed the tracking-optimization branch from e8198af to 24dad75 Compare May 18, 2022 22:12
@cwfitzgerald cwfitzgerald marked this pull request as ready for review May 24, 2022 05:50
@cwfitzgerald cwfitzgerald force-pushed the tracking-optimization branch from d807bd0 to 17a37a6 Compare May 24, 2022 05:55
@cwfitzgerald cwfitzgerald requested review from kvark and jimblandy May 24, 2022 05:57
@cwfitzgerald
Copy link
Member Author

Merging per discussion on the matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants