Many Steps Towards GL Testing Working #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
fix-gles-tests
branch
2 times, most recently
from
be7f457 to
265edd3
Compare
kvark
requested changes
Feb 24, 2022
cwfitzgerald
force-pushed
the
fix-gles-tests
branch
from
265edd3 to
f08c34a
Compare
This was referenced Feb 24, 2022
kvark
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Multiple issues have caused GL testing to not work in CI. This is the next step towards that.
Description
So first, I apologize, this PR got way out of control way quickly. I started with the goal of "fix up GL testing" but it turns out there were quite a few blockers here, so I had to resolve those... and suddenly I have 12 commits in the PR. I have more coming, but needed to cut it off before it got crazy.
Every commit is freestanding and should be reviewed individually, and I will make whatever changes using fixups.
Testing
Vk and Dx12 tests pass, GL still don't pass, but a lot more of them do than did before.