fix: blit should only draw one triangle #2474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original shader:
wgpu/wgpu/examples/mipmap/blit.wgsl
Lines 7 to 22 in 48f8811
x
in [0, 1]y
in [0, 1]out.tex_coord
in [(0, 0), (2, 2)]out.position
in [(-1, -3), (3, 1)]Clearly it is wrong, but it actually covers the whole render area([(-1, -1), (1, 1)]), and
tex_coord
happened to be right, so it worked.Testing
Run the mipmap example, result is the same.
master branch:
this branch: