-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dx11 Backend #2443
Dx11 Backend #2443
Conversation
2e8d332
to
376afd5
Compare
bc292e8
to
ae223b0
Compare
ae223b0
to
249dbbe
Compare
f71be86
to
d2dfa50
Compare
fce8c14
to
bd1589e
Compare
6c40f78
to
9b43006
Compare
Alright, this is ready for review, though dependent on gfx-rs/d3d12-rs#37. This factors out a lot of the DXGI code into common code, as well as implementing DX11 adapter enumeration. The DX11 backend is behind an environment flag so that it will not show up unless you externally as for it. The commits are self contained, but contain a dependency override on a fork, so it's up to you if to squash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
It looks mergable, I left a few notes in case you are going to do another iteration.
9b43006
to
6394ac6
Compare
6394ac6
to
f454a44
Compare
Description
At long last here is the PR that begins the Dx11 api. I'm making this PR early to make progress transparent and encourage comments as I build this out.
This first PR will aim to get us a working hello-triangle example, follow up PRs will build out more features. I'm trying to keep PRs as small as reasonable due to the hard lesseons we've learned in the past.
Testing
Doesn't work... yet :)