Support zero-sized mappings #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The workaround for the empty mapping is rather hacky. Open to better ideas :) |
|
Weird, CTS fails on Windows but passes on macOS. |
|
Closing this as out of date. |
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
* [hlsl-out] fix matCx2 as global uniform * [hlsl-out] update comments * [hlsl-out] fix `row_major` not being written on global arrays of matrices and also write it on nested arrays of matrices * [hlsl-out] fix matCx2's nested inside global arrays * [hlsl-out] fix struct members of type array<matCx2> * [hlsl-out] test mat2x4 to make sure our matCx2 code behaves properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
CTS
Description
Mapping an empty buffer should succeed still, and it should assume the mapped state.
That second part was missing.
Testing
Unlocks CTS