Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory init tracker refactor #1839

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Memory init tracker refactor #1839

merged 3 commits into from
Aug 23, 2021

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 21, 2021 •
edited
Loading

Connections
Moved out of #1688 for which it paves the way

Description

  • Splits memory tracker into reusable (for texture init tracker) and buffer specific parts
  • adds some documentation for memory init tracking
  • adds utility functions for checking if an init action is necessary and applies this everywhere (catching some places that were unchecked)

Wumpf added 3 commits August 21, 2021 14:40
@Wumpf
split out init_tracker module
44c7fbe 
with explicit buffer init tracking types
@Wumpf
Added shortcut methods for checked init action handling
c57e8ae 
Fixed a few unchecked sites in the process
@Wumpf
fix clippy warnings
80e8e9f
@Wumpf Wumpf mentioned this pull request Aug 21, 2021
Merged
@kvark kvark merged commit 9e1384d into gfx-rs:master Aug 23, 2021
@Wumpf Wumpf deleted the restructure-memory-init branch August 23, 2021 06:50
@Wumpf Wumpf mentioned this pull request Oct 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @kvark