Reproduce Naga's nicer error reporting for WGSL #1424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shouldn't this be using |
|
@ElectronicRU no, |
kvark
reviewed
Jun 20, 2021
| match naga::front::wgsl::parse_str(&code) { | ||
| Ok(module) => (None, Some(module)), | ||
| Err(err) => { | ||
| log::error!("Failed to parse WGSL code for {:?}: {}", desc.label, err); | ||
| log::error!("{}:", err); |
There was a problem hiding this comment.
err is already printed in the previous line
There was a problem hiding this comment.
Yeah I know. I just copied some lines over, without cleaning it up. At the moment this does nothing except print the error message twice :)
|
Any progress on this? |
Not from my end, I'm not sure how to proceed tbh. |
|
Closed by #1760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gfx-rs/wgpu-native#104
Basically, I find myself copying WGSL code to a file and running Naga from the command line on it, because that way I get prettier errors than when pushing the (faulty) WGSL via wgpu-native's
create_shader_module. Would be nice if the error reports were equally good.WIP: does not seem to help yet, except duplicating part of the error message.