Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaring something with name 'half' causes broken MSL generated. #4545

Closed
zakarumych opened this issue Oct 15, 2023 · 0 comments · Fixed by #4707
Closed

Declaring something with name 'half' causes broken MSL generated. #4545

zakarumych opened this issue Oct 15, 2023 · 0 comments · Fixed by #4707
Labels
area: naga back-end Outputs of naga shader conversion lang: Metal Metal Shading Language naga Shader Translator type: bug Something isn't working
Milestone
WebGPU Specificat...

Comments

@zakarumych
Copy link

zakarumych commented Oct 15, 2023 •
edited
Loading

It seems that half is used for a built-in type in MSL, so when a field with name half is declared in wgsl the resulting MSL cannot be compiled.
@teoxoy teoxoy added kind: bug lang: Metal Metal Shading Language area: naga back-end Outputs of naga shader conversion labels Oct 16, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added naga Shader Translator type: bug Something isn't working and removed kind: bug labels Oct 25, 2023
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Nov 3, 2023
fornwall added a commit to fornwall/wgpu that referenced this issue Nov 17, 2023
@fornwall
Add more metal keywords
461358a 
Fixes gfx-rs#4545.
@fornwall fornwall mentioned this issue Nov 17, 2023
Merged
fornwall added a commit to fornwall/wgpu that referenced this issue Nov 17, 2023
@fornwall
Add more metal keywords
696298e 
Fixes gfx-rs#4545.
fornwall added a commit to fornwall/wgpu that referenced this issue Nov 17, 2023
@fornwall
Add more metal keywords
846846c 
Fixes gfx-rs#4545.
fornwall added a commit to fornwall/wgpu that referenced this issue Nov 17, 2023
@fornwall
Add more metal keywords
04e47ac 
Fixes gfx-rs#4545.
fornwall added a commit to fornwall/wgpu that referenced this issue Nov 17, 2023
@fornwall
Add more metal keywords
7db34b1 
Fixes gfx-rs#4545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga back-end Outputs of naga shader conversion lang: Metal Metal Shading Language naga Shader Translator type: bug Something isn't working
Projects
None yet
Milestone
WebGPU Specification V1
Development

Successfully merging a pull request may close this issue.

Add more metal keywords fornwall/wgpu
3 participants
@zakarumych @cwfitzgerald @teoxoy