Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider lavapipe #3622

Closed
Tracked by #3678
jimblandy opened this issue Mar 27, 2023 · 2 comments · Fixed by #3873
Closed
Tracked by #3678

Reconsider lavapipe #3622

jimblandy opened this issue Mar 27, 2023 · 2 comments · Fixed by #3873
Labels
api: vulkan Issues with Vulkan

Comments

@jimblandy
Copy link
Member

The wgpu sources have various comments here and there remarking on how lavapipe doesn't implement Vulkan well enough to fully support WebGPU, but I wonder if that's true any more. Apparently Linux Mesa lavapipe 22.1.2 passes the Vulkan 1.3 CTS.

We should go through wgpu and see what works now and which caveats still apply. It would sure be nice to have lavapipe for software-based testing.

@jimblandy jimblandy added api: vulkan Issues with Vulkan area: tests Improvements or issues with our test suite and removed area: tests Improvements or issues with our test suite labels Mar 27, 2023
@teoxoy
Copy link
Member

teoxoy commented Jun 8, 2023

The zero_init_workgroup_mem test failing in CI (running via swiftshader currently) is becoming more and more prevalent. I wonder how lavapipe compares.

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jun 8, 2023

The zero_init_workgroup_mem test failing in CI is our fault not swiftshader's, it's the same thing affecting WARP: #3193

This wasn't obvious before as the vulkan validation layers were off. Afaict, there have been no spurious failures from swiftshader (that weren't our fault), but there have been quite a few from lavapipe. We should definitely try it again, but I have a lot more confidence in swiftshader than lavapipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants