Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of maxMemoryAllocationSize for the max_buffer_size limit #3326

Open
teoxoy opened this issue Dec 22, 2022 · 2 comments · Fixed by #3567
Open

Make use of maxMemoryAllocationSize for the max_buffer_size limit #3326

teoxoy opened this issue Dec 22, 2022 · 2 comments · Fixed by #3567
Labels
api: vulkan Issues with Vulkan type: enhancement New feature or request
Milestone
WebGPU Specificat...

Comments

@teoxoy
Copy link
Member

teoxoy commented Dec 22, 2022

Use VkPhysicalDeviceMaintenance3Properties::maxMemoryAllocationSize (part of VK_KHR_maintenance3) to query for the max_buffer_size limit.
@teoxoy teoxoy added type: enhancement New feature or request api: vulkan Issues with Vulkan labels Dec 22, 2022
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Dec 22, 2022
@teoxoy teoxoy mentioned this issue Mar 7, 2023
Merged
3 tasks
@teoxoy
Copy link
Member Author

teoxoy commented Aug 10, 2023

Mistakenly closed this, we only set max_memory_allocation_size for the allocator.

@teoxoy teoxoy reopened this Aug 10, 2023
@teoxoy teoxoy mentioned this issue Aug 10, 2023
Merged
2 tasks
@teoxoy
Copy link
Member Author

teoxoy commented Aug 18, 2023

There is also maxBufferSize, see https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkPhysicalDeviceMaintenance4PropertiesKHR.html.

We should probably use the minimum of the 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: vulkan Issues with Vulkan type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: No status
Milestone
WebGPU Specification V1
Development

Successfully merging a pull request may close this issue.

Set max_memory_allocation_size via PhysicalDeviceMaintenance3Properties jinleili/wgpu
1 participant
@teoxoy