y-flip should require vulkan 1.1 #2475
Labels
area: correctness
We're behaving incorrectly
good first issue
Good for newcomers
help required
We need community help to make this happen.
Description
Today, whether y-flip is supported (and whether we ignore the adapter) is determined here:
wgpu/wgpu-hal/src/vulkan/adapter.rs
Line 937 in 48f8811
Specifically, the vulkan 1.2 requirement may be too strict. My reading of https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VK_AMD_negative_viewport_height.html#_obsoletion_by_vk_khr_maintenance1_and_vulkan_1_1 seems to indicate that vulkan 1.1 is sufficient, and the check at the above location is safe to reduce to 1.1 for conformant drivers.
Repro steps
I hit this running on the panvk driver, which while not conformant, reports 1.1, but does not have the amd extension nor the
VK_KHR_maintenance1
extension.Expected vs observed behavior
Can run wgpu on vulkan 1.1 conformant driver.
The text was updated successfully, but these errors were encountered: