-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most of the samples have Vulkan swapchain validation errors #2286
Comments
We need a way for wgpu implementation to report back the surface size limits. And then, ideally, winit-based examples would respect those limits. |
That makes sense for the first one. I think this is actually a bug in winit. I see an erroneous resize event happening even in the winit examples. However, shouldn't wgpu refuse to execute the resize if it's outside the range of valid values (I do see a validation warning if I enable logging)? The second issue looks unrelated though. Should I open a different issue for that? |
yes, please
yes, it should. I suppose this validation check is missing. |
wgpu itself logs a warning (separate from the vulkan validation) but otherwise ignores it. |
This is now not a problem with up to date vulkan sdks |
* [spirv-out] Fix adding illegal decorators on fragment outputs. Furthermore, fix allowing to add `Centroid` and `Sample` decorator to vertex inputs. Fixes #2270 * Add test for fragment outputs * Fix fragment-output.wgsl test using more than 8 outputs in a single shader Breaks HLSL & MSL validation * formatting
Description
Most of the samples have validation errors.
Repro steps
All of the samples that open a window and render show this swapchain error:
Expected vs observed behavior
No validation errors
Platform
Windows 10
The text was updated successfully, but these errors were encountered: