Skip to content

Commit

Permalink
Fix Arcanization changelog (#4795)
Browse files Browse the repository at this point in the history
  • Loading branch information
a1phyr authored Nov 28, 2023
1 parent 238c373 commit fbbb7a0
Showing 1 changed file with 17 additions and 18 deletions.
35 changes: 17 additions & 18 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,24 +61,23 @@ Previously, `DeviceExt::create_texture_with_data` only allowed data to be provid

### Changes

- Arcanization of wgpu core resources:
Removed Token and LifeTime related management
Removed RefCount and MultiRefCount in favour of using only Arc internal reference count
Removing mut from resources and added instead internal members locks on demand or atomics operations
Resources now implement Drop and destroy stuff when last Arc resources is released
Resources hold an Arc in order to be able to implement Drop
Resources have an utility to retrieve the id of the resource itself
Remove all guards and just retrive the Arc needed on-demand to unlock registry of resources asap
Verify correct resources release when unused or not needed
Check Web and Metal compliation (thanks to @niklaskorz)
Fix tests on all platforms
Test a multithreaded scenario
Storage is now holding only user-land resources, but Arc is keeping refcount for resources
When user unregister a resource, it's not dropped if still in use due to refcount inside wgpu
IdentityManager is now unique and free is called on resource drop instead of storage unregister
Identity changes due to Arcanization and Registry being just the user reference
Added MemLeaks test and fixing mem leaks
By @gents83 in [#3626](https://github.com/gfx-rs/wgpu/pull/3626) and tnx also to @jimblandy, @nical, @Wumpf, @Elabajaba & @cwfitzgerald
- Arcanization of wgpu core resources: By @gents83 in [#3626](https://github.com/gfx-rs/wgpu/pull/3626) and thanks also to @jimblandy, @nical, @Wumpf, @Elabajaba & @cwfitzgerald
- Removed Token and LifeTime related management
- Removed RefCount and MultiRefCount in favour of using only Arc internal reference count
- Removing mut from resources and added instead internal members locks on demand or atomics operations
- Resources now implement Drop and destroy stuff when last Arc resources is released
- Resources hold an Arc in order to be able to implement Drop
- Resources have an utility to retrieve the id of the resource itself
- Remove all guards and just retrive the Arc needed on-demand to unlock registry of resources asap
- Verify correct resources release when unused or not needed
- Check Web and Metal compliation (thanks to @niklaskorz)
- Fix tests on all platforms
- Test a multithreaded scenario
- Storage is now holding only user-land resources, but Arc is keeping refcount for resources
- When user unregister a resource, it's not dropped if still in use due to refcount inside wgpu
- IdentityManager is now unique and free is called on resource drop instead of storage unregister
- Identity changes due to Arcanization and Registry being just the user reference
- Added MemLeaks test and fixing mem leaks

#### General

Expand Down

0 comments on commit fbbb7a0

Please sign in to comment.