Allow clippy::pattern_type_mismatch (#4887)

wgpu-core/src/device/resource.rs

@@ -3073,7 +3073,7 @@ impl<A: HalApi> Device<A> {
         if validated_stages.contains(wgt::ShaderStages::FRAGMENT) {
             for (i, output) in io.iter() {
                 match color_targets.get(*i as usize) {
-                    Some(&Some(ref state)) => {
+                    Some(Some(state)) => {
                         validation::check_texture_format(state.format, &output.ty).map_err(
                             |pipeline| {
                                 pipeline::CreateRenderPipelineError::ColorState(

wgpu-core/src/lib.rs

@@ -34,17 +34,15 @@
     // For some reason `rustc` can warn about these in const generics even
     // though they are required.
     unused_braces,
-    // Clashes with clippy::pattern_type_mismatch
-    clippy::needless_borrowed_reference,
+    // It gets in the way a lot and does not prevent bugs in practice.
+    clippy::pattern_type_mismatch,
 )]
 #![warn(
     trivial_casts,
     trivial_numeric_casts,
     unsafe_op_in_unsafe_fn,
     unused_extern_crates,
-    unused_qualifications,
-    // We don't match on a reference, unless required.
-    clippy::pattern_type_mismatch,
+    unused_qualifications
 )]
 
 pub mod any_surface;

wgpu-core/src/storage.rs

@@ -134,7 +134,7 @@ where
     pub(crate) fn label_for_invalid_id(&self, id: I) -> &str {
         let (index, _, _) = id.unzip();
         match self.map.get(index as usize) {
-            Some(&Element::Error(_, ref label)) => label,
+            Some(Element::Error(_, label)) => label,
             _ => "",
         }
     }

wgpu-core/src/track/range.rs

@@ -77,8 +77,8 @@ impl<I: Copy + Ord, T: Copy + PartialEq> RangedStates<I, T> {
     ) -> impl Iterator<Item = (Range<I>, &T)> + 'a {
         self.ranges
             .iter()
-            .filter(move |&&(ref inner, ..)| inner.end > range.start && inner.start < range.end)
-            .map(move |&(ref inner, ref v)| {
+            .filter(move |&(inner, ..)| inner.end > range.start && inner.start < range.end)
+            .map(move |(inner, v)| {
                 let new_range = inner.start.max(range.start)..inner.end.min(range.end);
 
                 (new_range, v)

wgpu-core/src/track/stateless.rs

@@ -42,7 +42,7 @@ impl<Id: TypedId, T: Resource<Id>> StatelessBindGroupSate<Id, T> {
         let resources = self.resources.lock();
         resources
             .iter()
-            .map(|&(_, ref resource)| resource.clone())
+            .map(|(_, resource)| resource.clone())
             .collect::<Vec<_>>()
             .into_iter()
     }