-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change artifact folder structure #417
Conversation
cc @Korijn I don't have a lot of experience with makefiles and shell scripts, so I would not be surprised if there are better ways to do things. E.g. I hate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge.
Though just noticed that ios archives (and the action name) have prefix iOS
instead of ios
making it inconsistent with other builds, would be good to have that fixed.
Will do that in a new pr |
Oh, I misunderstood your comment. Naming the archive to be lowercase is something that makes sense doing in this pr :) |
New builds on my fork: https://github.com/almarklein/wgpu-native/actions/runs/10717624628 |
Hi, i'm sorry if I didn't make it clear in the issue, but an intermediate In meta-build systems (cmake, meson, conan...) we'd want to do something like And if for any reason the project consuming wegpu wanted to use |
For my understanding, why the need for the subfolder? The name "webgpu.h" seems unique enough by itself. I.e. can't these simply use |
They can, but apparently the consensus is to use |
Closes #410
This updates the package command in the makefile to introduce a folder structure instead of putting all files in a flat namespace. The idea is to prepare the contents of the archive in a directory and then zipping that dir as a whole.
Results can be seen here: https://github.com/almarklein/wgpu-native/actions/runs/10703101259 (can others access these?)
One example: