Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nullable args in requestAdapter & requestDevice #239

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

rajveermalviya
Copy link
Collaborator

Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes things easier already.

The trick I ended up using in wgpu-py is to create the adapter, request its limit, and use these as the default limits for the device. (Will also post this on the corresponding issue, for future reference.) -> #218

@rajveermalviya rajveermalviya merged commit 169b516 into gfx-rs:master Jan 30, 2023
@rajveermalviya
Copy link
Collaborator Author

@almarklein can this be included in a new release?

(also what's the process of release in general, would creating a new tag be enough?)

@almarklein
Copy link
Collaborator

almarklein commented Jan 30, 2023

Sure!

(also what's the process of release in general, would creating a new tag be enough?)

Yes, you simply pass a tag called vA.B.C.D and CD does the rest. The idea is to follow the version of wgpu-core and then add a sequence number. So 0.14.2.4 is up next, I think.

edit: side-note: the version number is backed into the binary: the four numbers are packed into one uint.

@rajveermalviya
Copy link
Collaborator Author

Cool!, created v0.14.2.4

@rajveermalviya rajveermalviya deleted the nullable-args branch March 6, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants