Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[spv-out] Cache OpConstantNull #2414

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[spv-out] Cache OpConstantNull #2414

merged 1 commit into from
Aug 2, 2023

Conversation

evahop
Copy link
Contributor

@evahop evahop commented Jul 27, 2023 •
edited
Loading

Adds ZeroValue to cached constants and creates an associated get_constant_null function

Fixes #2334

teoxoy
teoxoy approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@teoxoy teoxoy merged commit f7de194 into gfx-rs:master Aug 2, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spv-out] ZeroValue expressions produce too many OpConstantNull instructions
2 participants
@evahop @teoxoy