Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[hlsl-out]: Document storage access generation. #2295

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy requested a review from teoxoy March 30, 2023 20:59
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had some non-blocking suggestions.

src/back/hlsl/storage.rs Outdated Show resolved Hide resolved
src/back/hlsl/storage.rs Outdated Show resolved Hide resolved
src/back/hlsl/storage.rs Outdated Show resolved Hide resolved
src/back/hlsl/mod.rs Outdated Show resolved Hide resolved
src/back/hlsl/mod.rs Outdated Show resolved Hide resolved
src/back/hlsl/storage.rs Show resolved Hide resolved
Copy link
Member Author

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've made the requested changes.

src/back/hlsl/storage.rs Outdated Show resolved Hide resolved
src/back/hlsl/storage.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2295 (744c47e) into master (52043be) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #2295   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files          82       82           
  Lines       44262    44262           
=======================================
  Hits        36379    36379           
  Misses       7883     7883           
Impacted Files Coverage Δ
src/back/hlsl/mod.rs 78.33% <ø> (ø)
src/back/hlsl/storage.rs 83.86% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jimblandy jimblandy merged commit da8e911 into gfx-rs:master Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants