This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
[msl-out] Update firstLeadingBit for signed integers #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
suggested changes
Feb 2, 2023
src/back/msl/writer.rs
Outdated
| let s = back::vector_size_str(size); | ||
| write!(self.out, "{NAMESPACE}::select(int{s}(")?; | ||
| write!(self.out, "{NAMESPACE}::floor(")?; | ||
| write!(self.out, "{NAMESPACE}::log2(float{s}(")?; |
There was a problem hiding this comment.
I would expect using a floating-point logarithm here to be much slower than using metal::clz. Could you see if that can work?
There was a problem hiding this comment.
Yeah small oversight on my part, I can fix this.
jimblandy
reviewed
Feb 2, 2023
jimblandy
approved these changes
Feb 2, 2023
|
Because I added a commit renaming a variable, GitHub stuck that "Co-authored" comment in there and I didn't notice it - but for the record, this PR is entirely @evahop's work. (Force-pushing to master is a pain for others, and we've got it disabled.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
firstLeadingBitto return-1when input is0or-1,and return the index of the first set
0bit for all other negative values.