This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
[spv-out] Emit required decorations on wrapper struct types, too. #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Apr 11, 2022
This was referenced Apr 11, 2022
|
Once #1823 lands, this can be rebased and land. |
jimblandy
force-pushed
the
decorate-synthetic-structs
branch
from
2c9db98 to
3e6ca58
Compare
Remove the `decorate_layout` variable, which is unconditionally set to `true` anyway.
jimblandy
force-pushed
the
decorate-synthetic-structs
branch
from
3e6ca58 to
01bf472
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1810. Draft PR because it contains no tests. Contains no tests because #1811.
[spv-out] Decorate array and struct type layouts unconditionally.
Remove the
decorate_layoutvariable, which is unconditionally set totrueanyway.