glsl-out: Add support for push constant emulation #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-out-push-constant
branch
from
bfc4cec to
0c2f100
Compare
kvark
approved these changes
Jan 16, 2022
|
@kvark I've added a test, it's basically a stripped down version of |
kvark
reviewed
Jan 16, 2022
| @@ -439,6 +439,7 @@ fn convert_wgsl() { | |||
| Targets::SPIRV | Targets::METAL | Targets::HLSL | Targets::WGSL | Targets::GLSL, | |||
| ), | |||
| ("extra", Targets::SPIRV | Targets::METAL | Targets::WGSL), | |||
| ("push-constants", Targets::GLSL), | |||
There was a problem hiding this comment.
Since extra enables push constants, could we just enable it instead of the new test?
There was a problem hiding this comment.
I wrote about it in my comment, extra.wgsl uses f64s which gles doesn't support
kvark
approved these changes
Jan 17, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for the glsl backend to output push constants as uniform buffers to allow for push constant emulation.
It only allows for one push constant per entry point, which is fine in my opinion since even vulkan glsl only allows one
push_constantdecoration per shader.It also changes the
ReflectionInfoto return a name of the uniform buffer used for the emulation if it was used andOptionsto take the binding to use for the buffer if explicit bindings are supported.This interface is deeply tied with the changes for push constant emulation on wgpu, so it might be useful to also see it JCapucho/wgpu@ee3887e
Note: I don't have much experience with openGL so the code might not be the best.