Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Fix data packing functions on MSL #1637

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Conversation

phoekz
Copy link
Contributor

@phoekz phoekz commented Dec 31, 2021

snorm and unorm got mixed up.

`snorm` and `unorm` got mixed up.
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow

@kvark kvark added the can backport PR that can be back-ported to a release branch label Dec 31, 2021
@kvark kvark enabled auto-merge (rebase) December 31, 2021 16:13
auto-merge was automatically disabled December 31, 2021 16:28

Head branch was pushed to by a user without write access

@phoekz
Copy link
Contributor Author

phoekz commented Dec 31, 2021

I forgot to update bits.msl test file, the diff test failed.

@kvark kvark enabled auto-merge (squash) December 31, 2021 16:42
@kvark kvark merged commit 6aca3e0 into gfx-rs:master Dec 31, 2021
kvark pushed a commit to kvark/naga that referenced this pull request Jan 12, 2022
* Fix data packing functions on MSL

`snorm` and `unorm` got mixed up.

* Fix bits.msl
@kvark kvark mentioned this pull request Jan 12, 2022
kvark pushed a commit that referenced this pull request Jan 12, 2022
* Fix data packing functions on MSL

`snorm` and `unorm` got mixed up.

* Fix bits.msl
@kvark
Copy link
Member

kvark commented Jan 12, 2022

Published in naga-0.8.2

@kvark kvark removed the can backport PR that can be back-ported to a release branch label Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants