Msl bounds checks #1532
Msl bounds checks #1532
Conversation
|
Because GitHub doesn't understand dependent PRs, this just incorporates a bunch of commits that I think could be reviewed and landed separately. I'll sort these out tomorrow. |
jimblandy
force-pushed
the
msl-bounds-checks
branch
3 times, most recently
from
c166082 to
33fde28
Compare
jimblandy
force-pushed
the
msl-bounds-checks
branch
from
33fde28 to
7f855e0
Compare
src/back/msl/writer.rs
Outdated
| writeln!(self.out, ")")?; | ||
| self.put_unchecked_store(pointer, value, level.next(), context) | ||
| } else { | ||
| self.put_unchecked_store(pointer, value, level, context) |
There was a problem hiding this comment.
nit: we could move this out of if/else
There was a problem hiding this comment.
I'm a tiny bit concerned if at some point put_unchecked_store implementation may decide to become multiple statements. Doing this in the "if (xx) y = z;" style will no longer work. Maybe we should anticipate this and use "{"/"}"?
There was a problem hiding this comment.
I've changed this to always put the store in brackets. That did make it awkward to move the put_unchecked_store out of the if. Since this was "nit", I didn't worry about it - but if you think it would still look better to hoist out that call (and add plumbing to indent it properly), we can totally do that.
jimblandy
force-pushed
the
msl-bounds-checks
branch
from
3b91528 to
0cc9a08
Compare
jimblandy
force-pushed
the
msl-bounds-checks
branch
5 times, most recently
from
379a012 to
4baffc8
Compare
|
Rebased, and a lot simpler. |
jimblandy
force-pushed
the
msl-bounds-checks
branch
from
4baffc8 to
7f49425
Compare
No changes in behavior.
jimblandy
force-pushed
the
msl-bounds-checks
branch
from
7f49425 to
80e794e
Compare
Fixes #1531.
Remaining work:
policy-mix.wgsltooanalyze_functionIndexInfo?choose_checksreuse a Vec to save allocationGuardedIndexandback::spv'sMaybeKnown