Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is naga::valid::TypeError::UnresolvedBase still needed? #2303

Closed
jimblandy opened this issue Apr 12, 2023 · 0 comments · Fixed by #2308
Closed

Is naga::valid::TypeError::UnresolvedBase still needed? #2303

jimblandy opened this issue Apr 12, 2023 · 0 comments · Fixed by #2308
Labels
area: validation Validation of the IR good first issue Good for newcomers

Comments

@jimblandy
Copy link
Member

The naga::valid::TypeError::UnresolvedBase error is only raised by Validator::validate_type, which is only called after Validator::validate_module_handles, which checks that all pointer, array, and struct member base type handles precede their uses.
So there should be no need for this error any more.

cc @ErichDonGubler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Validation of the IR good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(valid)!: remove TypeError::UnresolvedBase ErichDonGubler/naga
1 participant
@jimblandy