Associated types for ShaderParam #507
Conversation
| @@ -136,15 +140,18 @@ pub struct ParamDictionary { | |||
| pub textures: Vec<NamedCell<TextureParam>>, | |||
| } | |||
|
|
|||
| /// An associated link structure for `ParamDictionary` that redirects program | |||
| /// input to the relevant dictionary cell. | |||
| /// An associated parameter link for ParamDictionary | |||
There was a problem hiding this comment.
Could we change this comment to "Redirects program input to the relevant ParamDictionary cell"
|
Nice. Will this break you on alpha, @csherratt ? |
|
@bjz done! Too bad Travis is still lagging. |
|
Looks good. r+ if @csherratt is happy. |
|
No problem with the change. r+ I'd let travis to be happy before this gets merged. |
|
Still waiting on travis... :[ |
|
@bjz travis build failed due to the std::io -> std::old_io migration not being updated for by glfw-sys, which has since been fixed. @sectopod's branch builds for me locally with an updated gfx_gl with PR #10 (which was also just merged). I'm not sure if you can trigger a travis rebuild, but it should work now. |
|
@indiv0 thanks! restarting Travis... |
|
@indiv0 Travis is still failing in |
|
Well... if we don't merge, Travis is going to be failing on missing |
Associated types for ShaderParam
|
@kvark weird, it built for me locally. I'll take another look. EDIT: The merge commit built correctly though? EDIT2: Nevermind. I am a silly goose and forgot I applied these changes locally. |
507: Update logo and move bindings section r=kvark a=grovesNL - Adjust the logo slightly - Move the bindings section up slightly to hopefully reduce confusion for users coming to gfx-rs/wgpu looking for the Rust bindings (gfx-rs/wgpu-rs) - Also added some experimental Julia bindings - Open to other ideas how we can improve the repository naming confusion, though long term I think we may want to adjust the naming somehow (like we talked about before the sync was setup) [Rendered](https://github.com/grovesNL/wgpu-native/blob/8b19724364555c1855eda5349675d925ef0891f5/README.md) Co-authored-by: Joshua Groves <[email protected]>
Relies on the latest Rust changes in
TraitDef.Closes #400