Make CommandBuffer and associated type on Device #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -356,17 +356,18 @@ pub enum Command { | |||
| Blit(target::Rect, target::Rect, target::Mask), | |||
| } | |||
|
|
|||
| // CommandBuffer is really an associated type, so will look much better when | |||
|
Looks good to me. |
ghost
pushed a commit
that referenced
this pull request
Jan 25, 2015
Make CommandBuffer and associated type on Device
ghost
merged commit 
|
Awesome, the code looks much better now! |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
506: Bug 1614702 - WebGPU textures, texture views, and samplers r=gecko a=kvark This is a commit cherry-picked from gfx-rs#504 Co-authored-by: Dzmitry Malyshau <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles, but is broken by servo/core-foundation-rs#51