Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DX12 Backend to work with strides of 0 #3282

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Allow DX12 Backend to work with strides of 0 #3282

merged 1 commit into from
Jun 28, 2020

Conversation

cwfitzgerald
Copy link
Member

So this fixes the problem gfx-rs/wgpu#754 was working around, but found a much more interesting problem:

  • DX12 must have a stride of 16/20, the value of the stride is ignored other than the assert. This isn't a problem from the wgpu perspective (we assume tightly packed), but would have issues for gfx-portability.

kvark
kvark approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 28, 2020

Build succeeded:

@bors bors bot merged commit 4b25f06 into gfx-rs:hal-0.5 Jun 28, 2020
@cwfitzgerald cwfitzgerald deleted the dx12-count-fix branch October 20, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@monocodus monocodus[bot] monocodus[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @kvark