Flush on submit in GL when there are no sync capabilities
#2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also return an already signaled fence. This allows memory to be freed when used in `wgpu` without sync capabilities.
kvark
approved these changes
Jul 8, 2019
bors bot
added a commit
that referenced
this pull request
Jul 8, 2019
2893: Flush on `submit` in GL when there are no sync capabilities r=kvark a=hecrj Currently, when there are no sync capabilites, the GL backend returns an unsignaled fence on `submit` which only changes to signaled if `wait_for_fence` is called. This behavior causes memory to _never_ be freed when using WebGL2 on `wgpu`. The changes here flush immediately on `submit` in this case, and return an already signaled fence. I am not sure if this is the correct way to fix this. Let me know how to proceed. PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: - [ ] `rustfmt` run on changed code Co-authored-by: Héctor Ramón Jiménez <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when there are no sync capabilites, the GL backend returns an unsignaled fence on
submitwhich only changes to signaled ifwait_for_fenceis called. This behavior causes memory to never be freed when using WebGL2 onwgpu.The changes here flush immediately on
submitin this case, and return an already signaled fence. I am not sure if this is the correct way to fix this. Let me know how to proceed.PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code