Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ShaderParam::Link copyable again #521

Closed
kvark opened this issue Feb 4, 2015 · 2 comments · Fixed by #532
Closed

Make ShaderParam::Link copyable again #521

kvark opened this issue Feb 4, 2015 · 2 comments · Fixed by #532
Assignees
@kvark
Labels
difficulty: easy type: bug

Comments

@kvark
Copy link
Member

kvark commented Feb 4, 2015

Somewhere along the introduction of associated types to shader parameters, we lost Copy on the generated Link structure. This breaks PistonDevelopers/hematite#181

We might want to test for it (in tests).

cc @sectopod @bvssvni @toqueteos
@bvssvni
Copy link
Contributor

bvssvni commented Feb 4, 2015

A fn is_copy<T: Copy>() {} in a unit test might suffice.

@brendanzab
Copy link
Contributor

👍

@kvark kvark mentioned this issue Feb 5, 2015
Merged
@kvark kvark self-assigned this Feb 5, 2015
@kvark kvark closed this as completed in #532 Feb 5, 2015
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#521
d3e47fc 
521: Texture component type r=kvark a=kvark

Matching the upstream spec...

Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
difficulty: easy type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented Copy and Debug for ShaderParam::Link kvark/gfx
3 participants
@kvark @brendanzab @bvssvni